Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(loader): bump loader version #213

Closed
wants to merge 2 commits into from
Closed

Conversation

faris-imi
Copy link
Contributor

No description provided.

@faris-imi faris-imi self-assigned this Dec 4, 2023
@faris-imi faris-imi requested a review from a team as a code owner December 4, 2023 14:55
script.onerror(new Error('loading failed'));

// simulate microtask
await Promise.reject().catch(() => null)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brdlyptrs can you confirm that this microtask is expected to not work after latest @hcaptcha/loader update (as now it returns resolved promise or error instead of promise)

@brdlyptrs
Copy link
Collaborator

Closing this as this PR handles the tests and version update.

@brdlyptrs brdlyptrs closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants